Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ember 3.10, drops support for decorators #641

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
6 participants
@GavinJoyce
Copy link
Contributor

commented May 28, 2019

extracted from GavinJoyce#1
fixes #640 and resolves some of the issues described in #635

This PR is a breaking change as it drops support for decorators which have proven somewhat unstable. They were introduced a year ago in #583 so they are likely used by some apps. A good path forward would be to create ember-cp-validations-decorators which can depend on this addon and provide decorators support.

@GavinJoyce GavinJoyce force-pushed the GavinJoyce:gj/ember-3.10 branch 7 times, most recently from 8e24bd9 to 8c49695 May 28, 2019

@GavinJoyce GavinJoyce referenced this pull request May 29, 2019

Closed

Support ember 3.10.0 #1

@GavinJoyce GavinJoyce force-pushed the GavinJoyce:gj/ember-3.10 branch 2 times, most recently from 2935149 to 8ba9fec May 29, 2019

@GavinJoyce GavinJoyce changed the title [WIP] support ember 3.10 Support ember 3.10, drops support for decorators May 29, 2019

@GavinJoyce

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

This is passing on all scenarios except for beta and canary:

Screen Shot 2019-05-29 at 10 27 31

I've opened an issue to track that: #642

@GavinJoyce

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

We're running this in production for @intercom at the moment

@cah-danmonroe

This comment has been minimized.

Copy link

commented Jun 2, 2019

GavinJoyce/ember-cp-validations.git#8ba9fec36a2b3269bb95b66b0a2c68a832d6921d Fixes over 70 errors we had going from 3.9 to 3.10. Please merge

Show resolved Hide resolved addon/-private/options.js Outdated
@offirgolan

This comment has been minimized.

Copy link
Owner

commented Jun 3, 2019

@GavinJoyce thanks for taking the time to resolve all of the current issues! Once this PR gets merged, I'll release a new beta version.

If the decorator support has been causing so many issues, I say we remove it altogether and I'll make a note of it in the new beta version's changelog. Feel free to remove it completely if thats necessary to get this working in 3.10+.

@GavinJoyce GavinJoyce force-pushed the GavinJoyce:gj/ember-3.10 branch from 8ba9fec to d800333 Jun 4, 2019

@GavinJoyce GavinJoyce force-pushed the GavinJoyce:gj/ember-3.10 branch from d800333 to 6d18434 Jun 4, 2019

@GavinJoyce

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

@offirgolan I've removed the remaining references to decorators, this should be good to go now

@offirgolan offirgolan merged commit e037c99 into offirgolan:master Jun 4, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@offirgolan

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

Thanks @GavinJoyce! Released under v4.0.0-beta.9.

@offirgolan offirgolan referenced this pull request Jun 4, 2019

Closed

[WIP] Alon/fix decorators #636

0 of 2 tasks complete
@Alonski

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Awesome work @GavinJoyce !!!

@jderr-mx

This comment has been minimized.

Copy link

commented Jun 4, 2019

Awesome work, thank you!

@GavinJoyce GavinJoyce deleted the GavinJoyce:gj/ember-3.10 branch Jun 4, 2019

@alejandrodevs

This comment has been minimized.

Copy link

commented Jun 4, 2019

Awesome. Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.