refactor(mixins/table-header): set sharedOptions.fixed(Header|Footer)…

… once in init

This was previously done in the init of each component.

This also fixes the broken tests. `fixed` is *immutable*.

addon/components/lt-foot.js

@@ -1,5 +1,4 @@
 import Component from '@ember/component';
-import { get, trySet } from '@ember/object';
 import layout from 'ember-light-table/templates/components/lt-foot';
 import TableHeaderMixin from 'ember-light-table/mixins/table-header';
 
@@ -36,10 +35,5 @@ export default Component.extend(TableHeaderMixin, {
   classNames: ['lt-foot-wrap'],
   table: null,
   sharedOptions: null,
-
-  init() {
-    this._super(...arguments);
-
-    trySet(this, 'sharedOptions.fixedFooter', get(this, 'fixed'));
-  }
+  sharedOptionsFixedKey: 'fixedFooter'
 });

addon/components/lt-head.js

@@ -1,5 +1,4 @@
 import Component from '@ember/component';
-import { get, trySet } from '@ember/object';
 import layout from 'ember-light-table/templates/components/lt-head';
 import TableHeaderMixin from 'ember-light-table/mixins/table-header';
 
@@ -38,10 +37,5 @@ export default Component.extend(TableHeaderMixin, {
   classNames: ['lt-head-wrap'],
   table: null,
   sharedOptions: null,
-
-  init() {
-    this._super(...arguments);
-
-    trySet(this, 'sharedOptions.fixedHeader', get(this, 'fixed'));
-  }
+  sharedOptionsFixedKey: 'fixedHeader'
 });

addon/mixins/table-header.js

@@ -1,5 +1,5 @@
 import Mixin from '@ember/object/mixin';
-import { computed } from '@ember/object';
+import { computed, trySet } from '@ember/object';
 import { isEmpty } from '@ember/utils';
 import { warn } from '@ember/debug';
 import { inject as service } from '@ember/service';
@@ -146,8 +146,11 @@ export default Mixin.create({
   init() {
     this._super(...arguments);
 
-    let fixed = this.get('fixed');
-    let height = this.get('sharedOptions.height');
+    const fixed = this.get('fixed');
+    const sharedOptionsFixedPath = `sharedOptions.${this.get('sharedOptionsFixedKey')}`;
+    trySet(this, sharedOptionsFixedPath, fixed);
+
+    const height = this.get('sharedOptions.height');
 
     warn(
       'You did not set a `height` attribute for your table, but marked a header or footer to be fixed. This means that you have to set the table height via CSS. For more information please refer to:  https://github.com/offirgolan/ember-light-table/issues/446',

tests/integration/components/light-table-test.js

@@ -61,37 +61,45 @@ module('Integration | Component | light table', function(hooks) {
   test('fixed header', async function(assert) {
     assert.expect(2);
     this.set('table', new Table(Columns, createUsers(5)));
-    this.set('fixed', true);
 
     await render(hbs `
       {{#light-table table height='500px' id='lightTable' as |t|}}
-        {{t.head fixed=fixed}}
+        {{t.head fixed=true}}
         {{t.body}}
       {{/light-table}}
     `);
 
     assert.equal(findAll('#lightTable_inline_head thead').length, 0);
 
-    this.set('fixed', false);
+    await render(hbs `
+      {{#light-table table height='500px' id='lightTable' as |t|}}
+        {{t.head fixed=false}}
+        {{t.body}}
+      {{/light-table}}
+    `);
 
     assert.equal(findAll('#lightTable_inline_head thead').length, 1);
   });
 
   test('fixed footer', async function(assert) {
     assert.expect(2);
     this.set('table', new Table(Columns, createUsers(5)));
-    this.set('fixed', true);
 
     await render(hbs `
       {{#light-table table height='500px' id='lightTable' as |t|}}
         {{t.body}}
-        {{t.foot fixed=fixed}}
+        {{t.foot fixed=true}}
       {{/light-table}}
     `);
 
     assert.equal(findAll('#lightTable_inline_foot tfoot').length, 0);
 
-    this.set('fixed', false);
+    await render(hbs `
+      {{#light-table table height='500px' id='lightTable' as |t|}}
+        {{t.body}}
+        {{t.foot fixed=false}}
+      {{/light-table}}
+    `);
 
     assert.equal(findAll('#lightTable_inline_foot tfoot').length, 1);
   });