Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add label to base column to be used in column types #221

Merged
merged 1 commit into from
Oct 21, 2016

Conversation

offirgolan
Copy link
Collaborator

This puts label on the base column so it can be easily overwritten when defining new column types.

@HenryVonfire
Copy link

It worked like a charm with ember-intl 😄

export default Column.extend({
  intl: service(),
  label: computed('column.label', function () {
    return this.get('intl').findTranslationByKey(this.get('column.label'));
  })
});

@offirgolan offirgolan merged commit a19c5b8 into master Oct 21, 2016
offirgolan pushed a commit that referenced this pull request Oct 21, 2016
* master:
  chore(package): update broccoli-asset-rev to version 2.5.0 (#227)
  chore(package): update ember-data to version 2.9.0 (#230)
  chore(package): update ember-cli-mirage to version 0.2.3 (#232)
  Ember Suave + Cleanup (#234)
  Add label to base column to be used in column types (#221)
  chore(package): update ember-scrollable to version 0.3.4 (#226)
@offirgolan offirgolan deleted the base-column branch November 7, 2016 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants