[FEATURE] Responsive Columns #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnavas77
approved these changes
Oct 24, 2016
taras
approved these changes
Oct 24, 2016
There was a problem hiding this comment.
@offirgolan this looks good. Ideally, we wouldn't couple this implementation to ember-responsive but we can let demand dictate any future work. Great to see that there is a demo and tests! 👍
|
@taras I agree but at the same time I believe |
|
I agree too! |
* master: [FEATURE] ScrollTo and ScrollToRow (#228)
|
You guys are killin' it. Nice work! |
offirgolan
added a commit
that referenced
this pull request
Nov 7, 2016
* master: (42 commits) Resizable column fixes (#252) fix: repeated scrollToRow (#254) chore(package): update ember-cli-code-coverage to version 0.3.7 (#253) Demo Cleanup (#251) chore(package): update ember-lodash to version 0.0.11 (#245) chore(package): update ember-cli-code-coverage to version 0.3.6 (#249) Document `Row#content` (#250) Update resizable snippet Released v1.5.2 [FEATURE] minResizeWidth + Event bubbling fix (#244) Update readme Update readme Released v1.5.1 Add safe checks scroll logic (#241) [DOCFIX] Make breakpoints of demo app the same as ember-responsive's default (#240) Released v1.5.0 Demo + Scrolling Cleanup (#238) [FEATURE] Responsive Columns (#235) [FEATURE] ScrollTo and ScrollToRow (#228) chore(package): update broccoli-asset-rev to version 2.5.0 (#227) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #219.
This PR introduces a responsive solution. Using ember-responsive, I have introduced two methods to handle responsive behaviors that will hide the appropriate columns. This PR also introduces a new table property
responsiveHiddenColumnsto be able to easily distinguish between hidden columns and columns hidden from this responsive behavior.Via column definition
Specify an array of media breakpoints that determine when this column will be shown. If we have the following breakpoints defined in
app/breakpoints.js:And we want to show this column only for tablet and desktop media, the following array should be specified:
If this property is
null,undefined, or[], then this column will always be shown, regardless of the current media type.Via light-table component
Pass a hash to determine the number of columns to show per given breakpoint. If this is specified, it will override any column specific breakpoints. If we have the following breakpoints defined in
app/breakpoints.js:The following hash can be passed in:
If there is no rule specified for a given breakpoint (i.e.
desktop), all columns will be shown.