fabric/av: Introduce FI_SOURCE_ERR flag #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag requires that the provider report the raw address data for any address that is received which is not already inserted into the local AV. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
| were not inserted into the AV. This allows the provider to optimize | ||
| the reporting of the source fi_addr_t without the overhead of | ||
| verifying whether the address is in the AV. If full address | ||
| validation is necessary, FI_SOURCE_ERR must be used. |
There was a problem hiding this comment.
So this fi_addr_t may not be inserted in any AV? Will this still get released when the AV is closed?
| raw source addressing data be returned as part of completion data | ||
| for any address that has not been inserted into the local address | ||
| vector. Use of this capability may require the provider to | ||
| validate incoming source address data against addresses stored in |
There was a problem hiding this comment.
Isn't it more of a lookup than a validate?
|
The fi_addr_t is just a 64-bit value, so there's nothing to remove from the AV. No adjustments are made to the AV. This just documents that the provider may be forming the fi_addr_t values directly from the source address (like reporting a sockaddr_in as the fi_addr_t).
|
Well, the |
|
Yes - but in this case, the provider wouldn't be returning it. The case in question is where the provider can auto-generate an fi_addr_t value based on source addressing data. Providers that want to auto-generate pointers are on their own. :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag requires that the provider report the raw
address data for any address that is received which is not
already inserted into the local AV.
Signed-off-by: Sean Hefty sean.hefty@intel.com