New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/gni: Fix segfault when using FI_MULTI_RECV #3208

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
4 participants
@epaulson10

epaulson10 commented Aug 11, 2017

Signed-off-by: Erik Paulson erik.r.paulson@intel.com

Note that this is present in v1.5.0.

@hppritcha please review. I'm not sure if I'm supposed to put something like this in the libfabric-cray repo, but I figured this is small enough to just put upstream.

Erik Paulson
prov/gni: Fix segfault when using FI_MULTI_RECV
Signed-off-by: Erik Paulson <erik.r.paulson@intel.com>
@epaulson10

This comment has been minimized.

Show comment
Hide comment
@epaulson10

epaulson10 Aug 11, 2017

Updated this because I forgot that msg->desc is a pointer-to-a-pointer.

epaulson10 commented Aug 11, 2017

Updated this because I forgot that msg->desc is a pointer-to-a-pointer.

@shefty

This comment has been minimized.

Show comment
Hide comment
@shefty
Contributor

shefty commented Aug 11, 2017

@jswaro

This comment has been minimized.

Show comment
Hide comment
@jswaro

jswaro Aug 11, 2017

Contributor

The change makes sense. I'd be fine with it landing here. Thanks!

Generally speaking, I'd prefer to have these hit the ofi-cray repo first, but again - this is small and the change makes sense.

Contributor

jswaro commented Aug 11, 2017

The change makes sense. I'd be fine with it landing here. Thanks!

Generally speaking, I'd prefer to have these hit the ofi-cray repo first, but again - this is small and the change makes sense.

@jswaro

jswaro approved these changes Aug 11, 2017

@hppritcha hppritcha merged commit e0346e9 into ofiwg:master Aug 12, 2017

4 checks passed

DCO All commits have a DCO sign-off from the author
Signed-off-by checker This commit is signed off
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hppritcha hppritcha added the for-1.5.x label Nov 15, 2017

hppritcha added a commit to hppritcha/libfabric that referenced this pull request Nov 15, 2017

prov/gni: Fix segfault when using FI_MULTI_RECV
cherry-pick pr #3208 over to 1.5.x

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Erik Paulson <erik.r.paulson@intel.com>
(cherry picked from commit 17bf845)

hppritcha added a commit to hppritcha/libfabric that referenced this pull request Nov 15, 2017

prov/gni: Fix segfault when using FI_MULTI_RECV
cherry-pick pr #3208 over to 1.5.x

Signed-off-by: Erik Paulson <erik.r.paulson@intel.com>
(cherry picked from commit 17bf845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment