Bug Fixes #40

Merged
merged 10 commits into from Sep 12, 2012

Conversation

Projects
None yet
3 participants
Owner

ogail commented Sep 11, 2012

No description provided.

examples/Client/CloudStorageService.php
- $this->_tableProxy = TableService::create($config);
- $this->_blobProxy = BlobService::create($config);
- $this->_queueProxy = QueueService::create($config);
+ $connectionString = "DefaultEndpointsProtocol=http;AccountName=$name;AccountKey=$key";
@ogail

ogail Sep 12, 2012

Owner

Will fix the alignment.

@@ -82,7 +82,7 @@
* @author Azure PHP SDK <azurephpsdk@microsoft.com>
* @copyright 2012 Microsoft Corporation
* @license http://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0
- * @version Release: @package_version@
+ * @version Release: 0.3.1_2011-08
@jcookems

jcookems Sep 12, 2012

The date looks wrong, it is now 201_2_.

@jcookems

jcookems Sep 12, 2012

Also, this is slightly incorrect, in that the @Version tag is for the version in which it first appeared. But I guess bulk update is the most reasonable at this point. We will keep up to date with new APIs?

@jcookems

jcookems Sep 12, 2012

Ahh, my mistake. Forgot that the date referred to the service REST version, not our publish date. Looks good then.

@gcheng

gcheng Sep 12, 2012

however, do we really want to hard code the version ?

@ogail

ogail Sep 12, 2012

Owner

yeah, that's our intention from this change

The rest looks good.

ogail pushed a commit that referenced this pull request Sep 12, 2012

@ogail ogail merged commit f5b3658 into master Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment