New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LS_COLORS 01 and 04 detection #300

Merged
merged 1 commit into from Oct 8, 2017

Conversation

4 participants
@chetgurevitch
Contributor

chetgurevitch commented Oct 4, 2017

Necessary to correctly parse LS_COLORS as generated by dircolors.

@hoodie

This comment has been minimized.

Contributor

hoodie commented Oct 4, 2017

this could be put on the same line to avoid confusion:

                 "1" | "01"  => style = style.bold(),
                 "4" | "04"  => style = style.underline(),

@chetgurevitch chetgurevitch force-pushed the chetgurevitch:master branch from 7ef4c8d to b7551ff Oct 6, 2017

@chetgurevitch chetgurevitch force-pushed the chetgurevitch:master branch from 6e5597f to afc9657 Oct 6, 2017

@chetgurevitch

This comment has been minimized.

Contributor

chetgurevitch commented Oct 6, 2017

Done

@clarcharr

This comment has been minimized.

Contributor

clarcharr commented Oct 7, 2017

Is there a reason why the code is just directly matching strings instead of just parsing ints?

@ogham ogham merged commit 6b86cc4 into ogham:master Oct 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ogham

This comment has been minimized.

Owner

ogham commented Oct 8, 2017

Nice, thanks. 300 🎉

I'm not actually sure whether the ANSI codes are meant to be strings of digits or just integers. I just went with strings because I didn't think about trying to line the numbers up with one another.

@ogham

This comment has been minimized.

Owner

ogham commented Oct 9, 2017

I released this as a weekly if anyone wants this behaviour early: https://bsago.me/blog/exa/v0.9.0-weekly-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment