Skip to content

Add Roman::value_checked #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Add Roman::value_checked #5

merged 1 commit into from
Apr 25, 2020

Conversation

@syvb
Copy link
Contributor

@syvb syvb commented Apr 21, 2020

This adds Roman::value_checked. Unlike Roman::value, this returns an Err instead of panicking. I also added some tests to ensure it behaves correctly.

@syvb
Add value_checked, returns Err, not a panic
8f969fa 
Also added some tests to ensure that it works correctly.
@ogham ogham merged commit 8f41ec7 into ogham:master Apr 25, 2020
@ogham
Copy link
Owner

ogham commented Apr 25, 2020

Thanks!

@ogham
Copy link
Owner

ogham commented Apr 25, 2020

Released in 0.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syvb @ogham