New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer plugin #195

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@natrim
Contributor

natrim commented Aug 6, 2014

Composer plugin

  • add function "composer"
  • uses local composer if available
  • add function "composer_install" to install composer to current dir
@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Aug 8, 2014

Member

I don't understand this, there is no composer function defined on the composer.fish file.

Member

bpinto commented Aug 8, 2014

I don't understand this, there is no composer function defined on the composer.fish file.

@bpinto

View changes

Show outdated Hide outdated plugins/composer/composer.load Outdated
@bpinto

View changes

Show outdated Hide outdated plugins/composer/composer.load Outdated
@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Aug 8, 2014

Member

Have you considered adding this to fish also? I believe most, if not everything, could be added to fish.

Member

bpinto commented Aug 8, 2014

Have you considered adding this to fish also? I believe most, if not everything, could be added to fish.

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Aug 8, 2014

Contributor

updated the plugin to include function and removed aliases

Contributor

natrim commented Aug 8, 2014

updated the plugin to include function and removed aliases

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Aug 10, 2014

Member

I've reviewed this PR again and I feel like this pull request should be done on fish's github instead. Basically, only shell completions are being added here and fish already includes programs completions, could you open this PR there instead? Thanks.

Member

bpinto commented Aug 10, 2014

I've reviewed this PR again and I feel like this pull request should be done on fish's github instead. Basically, only shell completions are being added here and fish already includes programs completions, could you open this PR there instead? Thanks.

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Aug 11, 2014

Contributor

i removed the completions to another fish pull on fish-shell fish-shell/fish-shell#1607
the plugin now contains only the two functions "composer" and "composer_install"

Contributor

natrim commented Aug 11, 2014

i removed the completions to another fish pull on fish-shell fish-shell/fish-shell#1607
the plugin now contains only the two functions "composer" and "composer_install"

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Aug 12, 2014

Member

Nice!

Now, I have never used composer before. But is it possible to have it installed in several directories?

Member

bpinto commented Aug 12, 2014

Nice!

Now, I have never used composer before. But is it possible to have it installed in several directories?

@bpinto

View changes

Show outdated Hide outdated plugins/composer/composer.load Outdated
set PATH $COMPOSER_BIN_PATH $PATH
# get composer path
if test -z "$COMPOSER_BIN"

This comment has been minimized.

@bpinto

bpinto Aug 12, 2014

Member

What is this for? If the customer is already specifying $COMPOSER_BIN_PATH and/or enabling the plugin. It is expected to have binary accessible.

@bpinto

bpinto Aug 12, 2014

Member

What is this for? If the customer is already specifying $COMPOSER_BIN_PATH and/or enabling the plugin. It is expected to have binary accessible.

@bpinto

View changes

Show outdated Hide outdated plugins/composer/composer.load Outdated
@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Aug 12, 2014

Contributor

The composer is prefered to be installed to global PATH but, some ppl prefer to have it localy for every project.
Some ppl rename composer.phar to only composer, so it needs to be handled.
In a way you need to handle every possible way.

Contributor

natrim commented Aug 12, 2014

The composer is prefered to be installed to global PATH but, some ppl prefer to have it localy for every project.
Some ppl rename composer.phar to only composer, so it needs to be handled.
In a way you need to handle every possible way.

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Nov 20, 2014

Member

Instead of defining functions inside a .load we should have these functions on their own file.
ping @natrim

Member

bpinto commented Nov 20, 2014

Instead of defining functions inside a .load we should have these functions on their own file.
ping @natrim

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Nov 21, 2014

Contributor

split and repushed

Contributor

natrim commented Nov 21, 2014

split and repushed

@dwsturgeon

This comment has been minimized.

Show comment
Hide comment
@dwsturgeon

dwsturgeon Nov 21, 2014

I was just looking for a composer plugin. homebrew installs it globally links it and works great. My only thing is that the path needs amended to include ~/.composer/vendor/bin for composer executables. pretty easy fix.

dwsturgeon commented Nov 21, 2014

I was just looking for a composer plugin. homebrew installs it globally links it and works great. My only thing is that the path needs amended to include ~/.composer/vendor/bin for composer executables. pretty easy fix.

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Nov 22, 2014

Member

There is a mix of indentation, could you update everywhere to use two spaces for indentation ?

Member

bpinto commented Nov 22, 2014

There is a mix of indentation, could you update everywhere to use two spaces for indentation ?

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 22, 2014

Member

@bpinto That seems to be a fairly common request. Should we add an .editorconfig so that people whose editors are actually set up for it will get them configured properly for free?

Member

bobthecow commented Nov 22, 2014

@bpinto That seems to be a fairly common request. Should we add an .editorconfig so that people whose editors are actually set up for it will get them configured properly for free?

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Nov 22, 2014

Member

I'm not familiar with such file, could you help me adding it?

Member

bpinto commented Nov 22, 2014

I'm not familiar with such file, could you help me adding it?

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Nov 24, 2014

Contributor

ok, changed the spacing to 2 spaces

Contributor

natrim commented Nov 24, 2014

ok, changed the spacing to 2 spaces

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Nov 26, 2014

Member

I think the only thing left is to extract composer_install to its own file.

Member

bpinto commented Nov 26, 2014

I think the only thing left is to extract composer_install to its own file.

Composer plugin
- add function "composer"
- uses local composer if available
- add function "composer_install" to install composer to current dir
@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Nov 26, 2014

Contributor

ok, moved to own file

Contributor

natrim commented Nov 26, 2014

ok, moved to own file

@bpinto

This comment has been minimized.

Show comment
Hide comment
@bpinto

bpinto Nov 28, 2014

Member

Merged!!!

Member

bpinto commented Nov 28, 2014

Merged!!!

@bpinto bpinto closed this Nov 28, 2014

bpinto added a commit that referenced this pull request Nov 28, 2014

@natrim

This comment has been minimized.

Show comment
Hide comment
@natrim

natrim Nov 28, 2014

Contributor

yay
fluttershy_yay100

Contributor

natrim commented Nov 28, 2014

yay
fluttershy_yay100

@dwsturgeon

This comment has been minimized.

Show comment
Hide comment
@dwsturgeon

dwsturgeon Dec 3, 2014

woot thank you guys!

dwsturgeon commented Dec 3, 2014

woot thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment