Skip to content
Commits on Jan 29, 2009
  1. GitX 0.6.1

    Pieter de Bie committed Jan 29, 2009
  2. @anderscarling

    WebController: Set JS Controller after reloading the view

    The WebKit delegate method didStartProvisionalLoadForFrame:
    is not called when reloading the frame. This caused the
    webviews to appear empty.
    
    We fix it by using a delegate method which is called each
    reload, as suggested by weinig in #webkit.
    
    This fixes Lighthouse bug #81.
    anderscarling committed with Pieter de Bie Jan 29, 2009
Commits on Jan 28, 2009
  1. @heipei

    User manual: small typos/factual errors/missspellings

    Signed-off-by: Johannes Gilger <heipei@hackvalue.de>
    heipei committed with Pieter de Bie Jan 27, 2009
  2. RevList: Don't rely on the presence of %x00

    The %x00 pretty specifier was only added in git v1.5.6.
    This is quite new, so we try to support older git clients in
    GitX (v1.5.4 and up). In order to do this, we need to use another
    specifier.
    
    Unfortunately, we can't use a real \0 in our argument, as that just
    cuts off our argument string. So we get the next best thing -- we use
    \01 :).
    Pieter de Bie committed Jan 28, 2009
  3. @pieter

    Use new help page URL

    Some while ago, gitx changed its homepage from
    frim.nl/gitx to gitx.frim.nl, and in the process the user
    manual was moved. Though there is still a redirect in place,
    it's nicer for the user if we go to the correct page at once.
    pieter committed Jan 28, 2009
  4. @pieter

    CommitView: Show linebreaks with new files

    Just before releasing 0.6, I cleaned up some old code.
    In c689510 (Remove old code in Commit/Diff views),
    I removed some pre and code tags, causing new files
    in the commit view to be displayed without line breaks
    pieter committed Jan 28, 2009
Commits on Jan 26, 2009
  1. @pieter

    Update user manual for 0.6

    pieter committed Jan 26, 2009
  2. @pieter

    Update site to GitX v0.6

    pieter committed Jan 26, 2009
  3. @pieter

    GitX Version 0.6

    pieter committed Jan 26, 2009
  4. @pieter

    Merge branch 'pu/jg/rename_detection' (early part)

    * 'pu/jg/rename_detection' (early part):
      Diff: also show a binary when it's deleted
      DiffHighlighter: Properly show binary changes
      HistoryView: Prettify the file list
      Show renames changes by default
      history.css, history.js: Color changed/deleted/added/moved appendices
      Rudimentary support for renames/deletions of files
    pieter committed Jan 26, 2009
  5. @pieter
Commits on Jan 25, 2009
  1. @pieter

    Remove old code in Commit/Diff views

    We used to put diffs inside a <pre><code> block,
    but no longer need to do that as we now use tables anyway.
    We changed the code for the History view, but not for the
    other two views.
    pieter committed Jan 25, 2009
  2. @pieter

    DiffHighlighter: Properly show binary changes

    Binary changes don't have a +++ / --- line, just like
    a 100% rename doesn't show any changes. We work around
    this in much the same way -- by reading the filenames
    for that specific case.
    pieter committed Jan 25, 2009
  3. @pieter

    HistoryView: Prettify the file list

    Kim Does committed with pieter Jan 25, 2009
  4. @pieter

    CommitView: Remove a stray label

    pieter committed Jan 25, 2009
  5. @pieter
  6. @pieter

    HistoryView: Use the realSha for the searchfield predicate

    This still used the old sha value that we used before switching
    to libgit2, and thus caused  searching for sha's to fail
    pieter committed Jan 25, 2009
  7. @pieter

    Show renames changes by default

    Now that we have support to show file renames, we can
    enable it by default in all the diffs that we use.
    pieter committed Jan 25, 2009
  8. @heipei @pieter

    history.css, history.js: Color changed/deleted/added/moved appendices

    Signed-off-by: Johannes Gilger <heipei@hackvalue.de>
    heipei committed with pieter Jan 20, 2009
  9. @pieter

    Rudimentary support for renames/deletions of files

    diffHighlighter.js, history.js: Distinguish created, renamed, changed and deleted files and display them accordingly
    pieter committed Jan 20, 2009
  10. @pieter

    Update release notes

    pieter committed Jan 25, 2009
  11. @pieter

    WebHistoryView: Don't try to display PDF files anymore

    This used to work, but it probably changed with 1.5.6 or something,
    so let's just remove PDF support
    pieter committed Jan 25, 2009
  12. @pieter

    Change keyboard shortcuts for switching views

    This remaps Command-1/2 to the History/Commit view.
    
    The keys used to be used to switch the subview in the history view.
    As these views are probably less frequently changed than the history/
    commit view, we'd better use the easier shortcut for the latter.
    
    The subviews can now be changed by using command-option-1/2/3
    pieter committed Jan 25, 2009
  13. @pieter
  14. @pieter
  15. @pieter
  16. @pieter
  17. @pieter

    WebCommit: Fix displaying of files after multiselect

    This was borked when adding the context sizing, because
    the multiselect still changed the whole title rather than
    only the text span part.
    pieter committed Jan 25, 2009
  18. @pieter

    PBEasyPipe: Wait until exit if we're not in the main thread

    There have been numerous bug reports about zombie processes in GitX,
    because if an NSThread dies before an NSTask is finished it won't
    kill the child process properly.
    
    We tried to fix this by adding an [NSTask waitUntilExit] to wait for the
    process to die, fixing the problem with the zombies. However, this caused
    another problem: rendering glitches in the history view.
    
    The problem is that [NSTask waitUntilExit] does NOT wait until the task has
    finished (yeah, took me some time to figure that one out). Instead, it runs
    the main loop and periodically queries if the task has finished yet.
    
    What happens then is that during the drawing of one of the cells a call
    is made to [repository headRef] to determine whether we should show the
    cell in bold or not.
    
    [repository headRef] then invokes an NSTask to figure out what the HEAD ref
    really is. This in turn runs the [NSTask waitUntilExit].
    
    Now, rather than really wait, the NSTask continues the main loop, and Cocoa
    tries to display the next cell. This cell again calls an NSTask, etc...
    
    So, what we basically have then is that halfway through the NSCell's drawing
    code, the NSCell will be asked to draw another cell. It then changes the
    data members and calls the [drawInRect] stuff again. the cell finishes
    drawing, and control is returned to the previous draw. This path happily
    continues, but now its data members are changed because of the second
    draw, so it continues drawing something different than what it started
    with.
    
    As you might imagine, it took me some time to figure that one out :) The
    next part is to fix it, of course, which might be somewhat tougher.
    There's the easy fix to only [waitUntilExit] if the current thread is
    not the main thread. This fixes our problem because nothing is drawn
    in other threads, and nothing is zombie'd if it's called from the
    main thread.
    
    Another way is to fix the drawing code not to use data members. That
    way the drawing can continue happily as if nothing ever happend
    
    A third way is to fix the drawing part to never execute a git call.
    
    I think the first and third way are OK to do. The second option doesn't
    look very entertaining or practical.
    
    Of course, the first option is only working around the problem, and
    only solves this particular case. I guess this is one of those cases
    of "I'll work around it this time.. if it bugs me later, I'll fix
    it properly".
    pieter committed Jan 24, 2009
  19. @pieter

    PBGitCommit: Don't store refs

    We already keep this dictionary in our repository. Rather than adding a
    pointer to it on every commit in our rev walk, just look it up lazily in the
    dictionary when we need to. That cuts down some time in the initial revwalk
    and also removes some stupid code :)
    pieter committed Jan 24, 2009
Commits on Jan 21, 2009
  1. @pieter

    Gravatar: Sanitize email address before calculating MD5

    The MD5 of the email address that Gravatar uses should be without any
    capitalized characters or spaces.
    Till Salzer committed with pieter Jan 21, 2009
Commits on Jan 19, 2009
  1. @pieter

    PBRefController: Only set title if we have a rev

    We used to unconditionally set the title of the branch
    to the current branch. This worked fine in most cases
    where the current branch was already known, but failed
    when you use 'gitx -c' and then switch to the HistoryView,
    because then the currentBranch isn't known yet.
    
    The simple fix is to check if we know it. If we don't,
    it'll be set later on.
    pieter committed Jan 19, 2009
  2. @pieter

    DiffView: Fix displaying of diffs

    This was lost when changing the diff mechanism to
    highlight only a single div, rather than all diffs
    in the body.
    pieter committed Jan 19, 2009
  3. @pieter

    CommitView: Allow changing of context size

    This adds a slider in the commit view with
    which the user can change the context size.
    
    This is useful for example if the hunks are too
    big; by changing the context size, a hunk can be
    split and then the changes can be committed.
    pieter committed Jan 19, 2009
  4. @pieter

    CommitView: Actually show commit message

    The message that the commit was succesful used to disappear
    because after the commit, the index would refresh and another
    file would be shown. We fix this by never requiring a file to be
    selected.
    pieter committed Jan 19, 2009
Something went wrong with that request. Please try again.