Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage new RN JS Navigation #11

Closed
tlvenn opened this issue Jan 28, 2016 · 9 comments
Closed

Leverage new RN JS Navigation #11

tlvenn opened this issue Jan 28, 2016 · 9 comments

Comments

@tlvenn
Copy link

@tlvenn tlvenn commented Jan 28, 2016

Facebook is working on a revamp of the JS Navigator and the preview is available here: https://github.com/ericvicenti/navigation-rfc

@ohanhi I believe this would solve the major blocker with the current implementation of the Navigator.

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Jan 28, 2016

Oh wow. I will have to look into this. Thank you very much, @tlvenn!

@tlvenn
Copy link
Author

@tlvenn tlvenn commented Jan 29, 2016

Well I am glad I could be of help and thank you, @paulyoung and @staltz for this awesome project !

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Feb 15, 2016

Update: this is actually moving along nicely. NavigationExperimental is now in RN master branch, and there's some improvements to it already in progress: facebook/react-native#5912

@mk
Copy link
Contributor

@mk mk commented Feb 15, 2016

We tried updating react native to the current master in order to leverage the new navigation in master...mk:navigation-experimental but it seems changes to the require polyfill are currently breaking Elm.

We had to move the F2 etc functions of the generated elm.js up a level to get it to work, see 16db2a0

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Feb 23, 2016

@mk Interestingly, the anonymous function has always been there and it works under RN 0.14. But now that I am trying to upgrade to 0.21.0-rc, I am facing the same issue as you did: Can't find variable: F2. So strange.

@kommen
Copy link

@kommen kommen commented Feb 23, 2016

@ohanhi Yeah, I was really surprised by that as well. But what do you mean with "has always been there"? As far as I saw, the anonymous function in the processed version of elm.js gets wrapped one more time additionally after upgrading RN.

Sorry for just providing screenshots here, but I found these in my scrap notes when I was digging into the issue.

Before upgrading RN:
screen shot 2016-02-09 at 17 26 26

After upgrading RN:
screen shot 2016-02-09 at 17 26 16

This is from compiled index.ios.bundle which gets served from the react packager (prettified version).

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Feb 23, 2016

@kommen Where did you get that twice-wrapped file from? I can't see double (function() { rows in the compiled elm.js or in DevTools.

Edit: this was further discussed on the Elm Slack.

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Feb 24, 2016

The undefined functions issue was circumvented in #14
Our master is now using React Native 0.21.0-rc with #19

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Nov 30, 2016

With #44 and #49, I'd say this is now done!

@ohanhi ohanhi closed this Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants