Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes for React Native 0.55 #98
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
akavel
Jun 7, 2018
Uh oh!
I'm actually just now trying to revive https://github.com/opsb/elm-native-expo-counter
@nateabele I allowed myself to use your changes and merge them into https://github.com/akavel/elm-native-ui for use in https://github.com/akavel/elm-native-expo-counter. HUGE THANKS!!!
akavel
commented
Jun 7, 2018
•
|
Uh oh! I'm actually just now trying to revive https://github.com/opsb/elm-native-expo-counter @nateabele I allowed myself to use your changes and merge them into https://github.com/akavel/elm-native-ui for use in https://github.com/akavel/elm-native-expo-counter. HUGE THANKS!!! |
added a commit
to akavel/elm-native-ui
that referenced
this issue
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nateabele commentedJun 7, 2018
Just got this up and running on React Native 0.55 and React 16. Outside of removing references to
NavigationCardStack,NavigationHeader, andNavigationHeaderTitle, the only other change required (in my non-exhaustive test app, anyway) was this patch tomakeComponent():Happy to submit a PR, but obviously this breaks the navigation demo.😞 Let me know your thoughts. Thanks!