Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Return VTree from main #25
Hey, I figured it would make discussion / review easier if I make a separate PR, rather than continuing to comment on #24
To reacap: this depends on this fork of the elm compiler, which must be on your PATH before the standard elm compiler.
You also need to replace the
I went ahead and converted the Native code to ES5 syntax, since it doesn't need any fancy ES6 goodies, and it's nice to have a consistent style. However, it does still use
I also tried to generally clean things up a bit and added some comments to
Let me know if there's anything else that needs doing :)
I'm actually not sure it's possible, although if it is, that'd be great. The react native packager's
So, e.g. this won't work, since the packager can't know the value of
var pkg = './foo/bar'; require(pkg);
Renaming or otherwise wrapping
var foo = "require('./does/not/exist')";
which is why I think it's basically a regex, since it doesn't notice that the require is inside a string literal...
Ah, I see, it's something that ReactNative does differently? Here I use a shim - https://github.com/NoRedInk/take-home/blob/master/src/Native/Telate.js#L41
then I can include JS files like this:
then I can use
Yeah, the RN
It's kind of a drag, but I don't think it's a big priority for the RN team.