Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure project to work as an Elm package #26

Merged
merged 7 commits into from Mar 19, 2016
Merged

Conversation

@ohanhi
Copy link
Owner

@ohanhi ohanhi commented Mar 19, 2016

First off, I am sorry for the hugely noisy diffs in this branch. This is some pretty fundamental restructuring for the whole project, however, so noise is inevitable in that sense.

What I've done so far:

  • Moved all relevant package files to ./src
  • Moved usage example files to ./examples
  • Removed android and ios directories altogether
  • Renamed a bunch of stuff to be more intuitive for the end user

I also forked the compiler and core, but haven't yet updated them. My idea was that while we are in this phase of "DIY", it makes sense for the compiler and core modifications to be a part of the same project.

@eeue56
Copy link
Contributor

@eeue56 eeue56 commented Mar 19, 2016

What purpose do the android and ios folders have anyway? Where do they fit in? do they need to be part of core?

@ohanhi
Copy link
Owner Author

@ohanhi ohanhi commented Mar 19, 2016

@eeue56 No, they are generated by React Native when you start a project with react-native init MyProject. So it was always a little strange to have them in this repository.

@ohanhi ohanhi changed the title WIP: Restructure project to work as an Elm package Restructure project to work as an Elm package Mar 19, 2016
ohanhi added a commit that referenced this pull request Mar 19, 2016
Restructure project to work as an Elm package
@ohanhi ohanhi merged commit 8403e05 into master Mar 19, 2016
@ohanhi ohanhi deleted the only-elm-package-files branch Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants