Improve pattern matching of title for ignorable PRs

[rbmrclo]

Hi @ohbarye! When we used review bot, it seems like PR titles with [DO NOT MERGE] or [DON'T MERGE] are not being ignored, hence, still being returned in the list of PRs that needs review.

I did a quick sanitize in order to support the ignorable words I said above. Please review!

ignoreWords = ['wip', 'dontmerge', 'donotmerge']
regex = new RegExp(ignoreWords.join('|'), 'i')

title = "[Do not merge] This is a PR title"
title.replace(/'|\s+/g, '').match(regex)                  //  ‎✔ MatchObj {...}

title = "[Don't merge] This is another PR title"
title.replace(/'|\s+/g, '').match(regex)                  //  ‎✔ MatchObj {...}

[ohbarye]

Hi @rbmrclo, the honorable first-time contributor!
Thank you for the feedback and improvement, and adding a test as well.

This change is quite reasonable to me, but before merging, would you check my review comments?

[ohbarye]

Could you fix the following lint error?

$ yarn lint
yarn lint v0.27.5
$ eslint .

/Users/ohbarye/.ghq/github.com/ohbarye/review-waiting-list-bot/test/PullRequests.test.js
  10:42  error  Missing trailing comma  comma-dangle

✖ 1 problem (1 error, 0 warnings)
  1 error, 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.

[rbmrclo]

Sure! I actually didn't bother to run the lint when I was implementing this so I totally missed the comma-dangle. Fixed here b2a8aba

[ohbarye]

[minor] const pr is preferable here since the variable is immutable.

[rbmrclo]

Ah right, thanks for pointing that out! Updated here 9945d20

[ohbarye]

Thanks for your quick fix! LGTM 👍

[rbmrclo]

Woohoo! Thanks!!! 🚀