Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename feature_index to variable_source #68

Closed
kzollove opened this issue Sep 16, 2022 · 3 comments · Fixed by #73
Closed

Rename feature_index to variable_source #68

kzollove opened this issue Sep 16, 2022 · 3 comments · Fixed by #73
Labels
R Package Pertinent to the R Package SQL Pertinent to the database

Comments

@kzollove
Copy link
Collaborator

The name feature_index is confusing as "feature" means something different in the context of this project than in the wider GIS community. Instead of the term "feature", we will use the term "variable" which is functionally equivalent in the context of the project. Further, we will address the fact that this table is not exactly an index, but more like a second source table due to the amount of unique data it contains.

Changes should be made in the SQL db and in the R code that touches the SQL db.

@kzollove kzollove added R Package Pertinent to the R Package SQL Pertinent to the database labels Sep 16, 2022
@kzollove
Copy link
Collaborator Author

kzollove commented Sep 16, 2022

In SQL this change entails:

  • Changing table name from feature_index to variable_source
  • Changing column names that use "feature" or "feature_index" to "variable" or "variable_source"

@kzollove
Copy link
Collaborator Author

Pretty much right as I was finishing this it hit me that this should be called variable_registry

@rtmill thoughts? Worth changing again?

@rtmill
Copy link
Collaborator

rtmill commented Sep 21, 2022

@kzollove If you feel strongly enough about it being a better fit to give you the motivation to make the change, the name makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R Package Pertinent to the R Package SQL Pertinent to the database
Projects
Status: ✔Done
Development

Successfully merging a pull request may close this issue.

2 participants