README edits #141

Merged
merged 3 commits into from Mar 8, 2014

Projects

None yet

2 participants

@kookster
Contributor
kookster commented Mar 7, 2014

I made some general edits, but mostly tried to improve the info on processing modes and Rails support.
Hope this is helpful.

kookster added some commits Mar 7, 2014
@kookster kookster Updated README
Edited section on modes in description to reflect as_json instead of to_hash.

Added section regarding Rails compatibility, created new heading for Compatibility.

Broke out the JSON Processing Alternatives section, and edited.
1f08e57
@kookster kookster A bit more editing
Read it over a bit more and edited a few more things, changed the formatting a bit.
Hope you don't mind and find this helpful.
25d9c78
@kookster kookster more edits top rails section
take -> make, and more specifics for how to get Oj working with which version.
9ac2e2e
@kookster
Contributor
kookster commented Mar 7, 2014

FWIW - I did actually test using oj_mimic_json with a basic Rails 4-1-stable branch based app, and it worked:

irb(main):005:0* json = JSON.dump([1, true, nil])
=> "[1,true,null]"
irb(main):006:0> Oj.default_options= {:indent => 2}
=> {:indent=>2}
irb(main):007:0> json = JSON.dump([1, true, nil])
=> "[\n  1,\n  true,\n  null\n]"
@ohler55 ohler55 merged commit 2ddd42f into ohler55:master Mar 8, 2014

1 check passed

default The Travis CI build passed
Details
@ohler55
Owner
ohler55 commented Mar 8, 2014

Thanks for the cleanup. Good news on 4.1 tests. Thanks for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment