New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAX parser failed test case. #46

Closed
Synix opened this Issue Mar 5, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@Synix

Synix commented Mar 5, 2013

We used ox parser, its performance is outstanding.
But we found there is a failed test case, just like below:

<?xml version="1.0"?><abcdefghijklmnop></abcdefghijklmnop>

As we guess, the reason maybe is that the code doesn't handle 16-letters length element name correctly.

You could have a try to test this. Waiting for your reply...

@flanker

This comment has been minimized.

flanker commented Mar 5, 2013

if you add following test into test_sax_nested_same_prefix in sax_test. the test will fail.

Ox.sax_parse(handler, StringIO.new(%{<?xml version="1.0"?><abcdefghijklmnop></abcdefghijklmnop>}))
assert_equal([], handler.errors)
@ohler55

This comment has been minimized.

Owner

ohler55 commented Mar 10, 2013

Sorry for the delay getting back to you. I was able to recreate the bug and will fix it.

@ohler55

This comment has been minimized.

Owner

ohler55 commented Mar 10, 2013

Released 1.9.2 with the fix. Tough to find. An off by 2 memory error.

@Synix

This comment has been minimized.

Synix commented Mar 11, 2013

Well done! We will try released 1.9.2 later.

@Synix Synix closed this Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment