Improve loading extension #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, RubyGems may stop copying compiled extensions into the installed gem lib's directory, and may only install them into arch-specific locations. So it's better to not rely on the extension being present there, and rely on the `$LOAD_PATH` instead.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RubyGems, we are considering to stop installing extensions into the lib directory of the installed gem.
If we made such change, this gem would break because it relies on the extension being present in the same directory as lib code.
This PR changes things to not make such assumption and instead rely on the
$LOAD_PATH.