Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile linting #52

Closed
Leopere opened this issue Oct 9, 2019 · 5 comments

Comments

@Leopere
Copy link

commented Oct 9, 2019

https://github.com/hadolint/hadolint/wiki/DL4000 for the now deprecated MAINTAINER directive can be replaced with LABEL maintainer

https://github.com/hadolint/hadolint/wiki/DL3016 for npm and apk add we should likely be pinning versions, its more maintenance for us as the repository maintainers but its smart long term as we won't break peoples installations in the future if we do it this way. Either this or we should ensure to get some CI/CD tests setup to validate that what we push is 100%

@Leopere Leopere added this to To do in Needs via automation Oct 9, 2019
@Leopere Leopere added this to To do in OhMyForm 1.0 via automation Oct 9, 2019
@Leopere

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

Also ensuring that we reduce layers as much as possible is always a plus but once this one is closed the Dockerfile is relatively 1.0 ready.

@mhmoosazadeh

This comment has been minimized.

Copy link

commented Oct 9, 2019

@Leopere Hi, Do you mean you want to have a multistage Dockerfile? A step for checking the project test? If yes, I think I can help with it.

@Leopere

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

@mhmoosazadeh thanks for your quick reply, thats not exactly the priority here it was more a mention to the fact that ultimately that would be ideal. However, in the mean time we could just have a couple of tested pinned packages. Aka whatever is the latest possible release version of the packages required to run OhMyForm those are the ones that should be pinned in the Dockerfile.

@mhmoosazadeh

This comment has been minimized.

Copy link

commented Oct 9, 2019

@mhmoosazadeh thanks for your quick reply, thats not exactly the priority here it was more a mention to the fact that ultimately that would be ideal. However, in the mean time we could just have a couple of tested pinned packages. Aka whatever is the latest possible release version of the packages required to run OhMyForm those are the ones that should be pinned in the Dockerfile.

Good, So please assign it to me.

@Leopere Leopere closed this Oct 9, 2019
Needs automation moved this from To do to Done Oct 9, 2019
OhMyForm 1.0 automation moved this from To do to Done Oct 9, 2019
@Leopere

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Needs
  
Done
OhMyForm 1.0
  
Done
2 participants
You can’t perform that action at this time.