Agnoster theme prompt extremly slow in mercurial

[MerliX]

Code here https://github.com/robbyrussell/oh-my-zsh/blob/3d2bf227ea2b37d351ac3846627f28151e0a4480/themes/agnoster.zsh-theme#L111 runs very slow (mac yosemite)

[apjanke]

FYI, if you're going to link to lines of code (or files for that matter) in a bug report, you should link to a specific commit, instead of "master" or another branch name. Otherwise, later commits may shift around line numbers and your link will be pointing at a different piece of code. (For example, we're about to merge a commit to agnoster that will probably shift everything down a few lines, and your link will be pointing in to the zstyle commands inside prompt_git.)

https://github.com/robbyrussell/oh-my-zsh/blob/3d2bf227ea2b37d351ac3846627f28151e0a4480/themes/agnoster.zsh-theme#L111

[MerliX]

@apjanke thanks for advice

[apjanke]

How slow is "extremely slow" for you? This stuff is all relative. :)

I'm trying it out on OS X 10.9.5 Mavericks, on an SSD MacBook Pro. In a newly created Hg repo, it feels like it takes between half a second and a second to issue the prompt. That feels pretty slow to me. But is also not a huge surprise: this is not a very fast theme, and it's doing hg shellouts.

This could maybe be improved by consolidating the hg calls and doing parsing with native zsh string stuff afterwards. And the hg prompt test could be done once at theme load time.

[apjanke]

Oh, yeah, we can totally speed this up. Half those hg calls are unnecessary. I'll give it a try when I have some free time, maybe later today.

[MerliX]

I did a quick fix for this, but it is not so functional. However, probably it will help

prompt_hg() {
  local rev_branch st hg_status
  rev_branch=$(hg id -n -b 2>/dev/null)

  if [ ! -z "$rev_branch" ] ; then
    st=""
    hg_status=`hg st`
    if `echo $hg_status | grep -q "^\?"`; then
      prompt_segment red black
      st='±'
    elif `echo $hg_status | grep -q "^[MA]"`; then
      prompt_segment yellow black
      st='±'
    else
      prompt_segment green black
    fi
    echo -n "☿ $rev_branch" $st
  fi
}

By the way, I switched my console to https://github.com/bhilburn/powerlevel9k witch is way more fast from-the-box

[apjanke]

Thanks!

Interesting. PowerLevel9K is relying entirely on zsh's own vcs_info for the Hg stuff, instead of rolling its own. I'll look in to that and see if it's an option for us, too.

[dritter]

@apjanke Jep. vcs_info uses mostly hexdump to get the information from the repository and invokes mercurial only once.

[apjanke]

Oh, nice. I see some vcs_info in my future, in that case.

[apjanke]

Agnoster now has its own repo, https://github.com/agnoster/agnoster-zsh-theme, and is using Zsh vcs_info. Can you give the upstream theme a try and see if it's still slow for you?

[MerliX]

Well, its not slow anymore, but it neither shows hg info in zsh prompt =) Built-in agnoster theme is still slow in hg repo. I am happy with powerlevel9k theme by the way

[apjanke]

Oh yeah, the hg support was an OMZ addition. Nevermind about asking upstream. :)

[Cypher1]

Will this improve anytime soon? I'm having similar issues with bullettrain (which is based on agnoster).
I'm having multiple seconds of waiting time between prompt renders in a largish hg repo.

[caugner]

Steps to reproduce:

hg clone https://hg.mozilla.org/mozilla-central
cd mozilla-central
time (prompt_hg > /dev/null)
# ( prompt_hg > /dev/null; )  2.77s user 1.19s system 99% cpu 3.971 total 

[caugner]

The lag stems from the three calls to hg id on lines 155 and 172/173 and hg st on line 174/177:

hg clone https://hg.mozilla.org/mozilla-central
cd mozilla-central

time hg id
# hg id  0.66s user 0.35s system 99% cpu 1.020 total

time hg id -n
# hg id -n  0.65s user 0.38s system 99% cpu 1.032 total

time hg id -b
# hg id -b  0.08s user 0.03s system 99% cpu 0.117 total

time hg st
# hg st  1.32s user 0.41s system 99% cpu 1.733 total