Update not working (error with upgrade.sh)

[ashmoran]

I can't update Oh My Zsh from inside the shell. This is my shell session showing what goes wrong:

Last login: Sun Aug 14 09:42:19 on ttys002
[Oh My Zsh] Would you like to check for updates?
Type Y to update oh-my-zsh: y
/bin/sh: /tools/upgrade.sh: No such file or directory

Here is my .zshrc (zsh_app_switcher is just a simple function):

ZSH=$HOME/.oh-my-zsh
ZSH_THEME="robbyrussell"
plugins=(osx brew rvm gem bundler git rails3)
source $ZSH/oh-my-zsh.sh
export PATH=/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11/bin
source /Users/ashleymoran/.dotfiles/zsh_app_switcher
export EDITOR="mate -w"
export SVN_EDITOR="mate -w"
alias nano="nano -w"
export DARCS_EMAIL=ash.moran@patchspace.co.uk
if [[ -s /Users/ashleymoran/.rvm/scripts/rvm ]] ; then source /Users/ashleymoran/.rvm/scripts/rvm ; fi

[iernie]

I also have this problem. Seems that the variable $ZSH is empty within the upgrade script. Works if I hardcode the path to .oh-my-zsh in the tools/upgrade.sh script.

[jonand]

I also had troubles upgrading.

Manually executing git pull origin master worked.

Iernies trick worked. Seems like $ZSH isn't working inside upgrade.sh even though it is working otherwise.

[bbatsov]

Same problem here. Hopefully it will be fixed upstream soon.

This was introduced by commit 1a673fc

--- templates/zshrc.zsh-template
+++ templates/zshrc.zsh-template
@@ -1,18 +1,18 @@
 # Path to your oh-my-zsh configuration.
-export ZSH=$HOME/.oh-my-zsh
+ZSH=$HOME/.oh-my-zsh
…

Temporary workaround, change your ~/.zshrc to export ZSH again:

export ZSH=$HOME/.oh-my-zsh

[danishkhan]

Thanks for the temporary workaround

[fabalca]

worked as well.. thanks #toolbear

[trevor]

+1

[chelmertz]

+1

[levifig]

Folks: there's no new update since August 30 hence no updates coming with 'git pull origin master'. When there are updates, this issue will be fixed. Just be patient… :)

[Fitzsimmons]

Why doesn't this issue warrant an update?

[kud]

Hello,

I'm a bit lost, sorry. I've got this problem and I can't install oh-my-zsh because I've already installed it (makes sense).

So what should I do?

Thank you!

_kud

@kud have you tried the temporary workaround #549 (comment)

[kud]

I've pulled the git repo and added your line, seems ok. Cheers!

[trevor]

does anyone know why this isn't being resolved? while not critical, it seems jarring and widespread.

[sunaku]

I think most people get by with a simple git pull --rebase origin master to upgrade their OMZ forks. In that light, I personally think this upgrade script is redundant / overkill. 👮