Heroes vanish when they die instead of showing their dead frames

[ohrrpgce-bugbot]

[bz#765]

When a hero dies in battle they simply vanish. Their death frame is not displayed. This is apparently a very recent bug. Perhaps caused by the new death fades for monsters?

From: @bob-the-hamster
Reported version: 20110506 Zenzizenzic

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

Yep, this started in svn revision 2951 (7361b8e), which is the one that added the new enemy dissolve types.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

Aha! Got it.

When TMC implemented the new dissolve types, cleaned up the code so that bslot().dissolve was only set for enemies, which makes sense.

Unfortunately, .dissolve was also used by heroes to trigger the animate: GOSUB block to force the hero to use their death frame.

I fixed it so that hero's .dissolve gets set = 1 when they die, which fixes this bug.

This is not the most elegant way to handle hero death frames, but it is the way that worked before.

This area of code will get some further clean-up in the future.