Map related incompatibility with at least 1 old game.

[ohrrpgce-bugbot]

[bz#952]

Taoki noticed a problem in Philip's Adventure which happens with the latest nightly build but not with the Zenzizenzic release.
http://www.castleparadox.com/gamelist-display.php?game=1019

To reproduce, after the opening cutscenes, when you take control of Philip, walk outside of the house. In Zenzizenzic, this took you to the town map. In the nightlies, it takes you to a field of grass. You cannot even see your player. Waking around scrolls the grass.

Taoki managed to narrow down the point in which this bug started.

Taoki Wow... interesting. In 2011-06-01, it all works well. In 2011-06-20, the
environment keeps blinking and flashing. In 2011-07-01, it stops showing at all

This means that the bug is probably related to the conversion from the old map drawing code to the new code that draws with mapslices.

From: @bob-the-hamster
Reported version: 20120615 Alectormancy

[ohrrpgce-bugbot]

Comment author: @rversteegen

What a coincidence. I somehow found myself looking at that game listing on CP just a day or two ago, and I was this close to downloading and playing it.

[ohrrpgce-bugbot]

Comment author: @rversteegen

Oh I think this game was actually linked from somewhere recently. I had thought I clicked it in the game list. Nevermind.

Thank goodness for the slice "debugger". Hiding map layers 1 and 2 fixes the symptom.

Looking at the scripts shows no slice commands were used.

Looking in Custom shows that those layers are disabled ("Hidden in-game").

Grepping the source shows that these bits aren't checked anywhere in-game. Opps.

git log -S"readbit(gmap" shows that the code was removed in r4461 (d076ace), but it had already been disabled before then. It was never reimplemented. Only took 8 months to notice!