Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

不明を参照するのを忘れてた #112

Merged
merged 1 commit into from Nov 22, 2020
Merged

Conversation

ohyama4z
Copy link
Owner

@ohyama4z ohyama4z commented Nov 22, 2020

close #111


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@codecov-io
Copy link

Codecov Report

Merging #112 (856f637) into master (74d6b0a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   98.24%   98.25%   +0.01%     
==========================================
  Files          13       13              
  Lines         682      686       +4     
  Branches       65       69       +4     
==========================================
+ Hits          670      674       +4     
  Misses         12       12              
Impacted Files Coverage Δ
client/src/components/Sidebar.vue 92.40% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d6b0a...856f637. Read the comment docs.

Copy link
Contributor

@satackey satackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードは流し読みだけど、CSVの全項目が空のもの(不明)、一部が空のもの(不明)、全部埋まってるもの(不明でない)を全て確認できたのでヨシ!

(ちなみに僕は Collaborator ではないので Approve しても Admin merge になるのは変わりない)

At least 1 approving review is required by reviewers with write access.

@satackey
Copy link
Contributor

この辺り、後々ちゃんとテストにできるとよいですね

@ohyama4z
Copy link
Owner Author

(投げ銭をされるのはadmin mergeより遥かに心臓に悪いけれども) ありがとうございます

@ohyama4z ohyama4z merged commit e28bbc8 into master Nov 22, 2020
@ohyama4z ohyama4z deleted the fix_clicked_unknown_item branch November 22, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants