Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 3.8.0 Regression for User Creation Failure When No Nickname #390

Merged

Conversation

timnolte
Copy link
Collaborator

@timnolte timnolte commented Mar 9, 2022

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Setup OIDC plugin with an IDP that doesn't provide a nickname or set the nickname in the configuration to blank.
  2. Confirm that user creation is successful with a fallback to using displayname.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

This fix addresses a regression is causes in release 3.8.0 that wouldn't allow the fallback to displayname to be used for the WordPress nickname if a nickname key wasn't provided by the IDP or configured in the settings.

@timnolte timnolte force-pushed the fix/243-nickname-from-claim-regression branch from a34b247 to c291b13 Compare March 15, 2022 02:46
* Fixes the regression caused by the code changes in 3.8.0
  which resulted in not performing proper fallbacks for
  missing cliams such as the nickname.
* Fixes invalid Node version in NVM configuration.
@timnolte timnolte force-pushed the fix/243-nickname-from-claim-regression branch from c291b13 to 64f87d3 Compare March 15, 2022 02:48
@timnolte timnolte marked this pull request as ready for review March 15, 2022 02:49
@timnolte timnolte added the bug label Mar 15, 2022
@timnolte timnolte added this to the 3.9.0 milestone Mar 15, 2022
@timnolte timnolte merged commit 5d11431 into oidc-wp:dev Mar 17, 2022
@timnolte timnolte deleted the fix/243-nickname-from-claim-regression branch March 17, 2022 01:02
@timnolte timnolte added the status: approved PRs that have been approved and ready to be merged. label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: approved PRs that have been approved and ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user-creation failed if claims does not contain nickname_key (3.8.0 regression)
1 participant