^C exits osh instead of foreground process

[acg]

$ echo $SHELL
/bin/bash
$ osh
osh$ cat
^C
$ echo $SHELL
/bin/bash

[acg]

Same with handling of other terminal signals (^Z).

[acg]

Same with handling of other terminal signals (^Z).

[andychu]

Thanks good point. Yes OSH isn't doing any signal handling at all right now.

I forget exactly how it works but I think we have to change the session group when starting a process. That way signals only get delivered to cat and not to osh.

I have to implement the trap builtin too so this could be done at the same time.

[andychu]

Thanks good point. Yes OSH isn't doing any signal handling at all right now.

I forget exactly how it works but I think we have to change the session group when starting a process. That way signals only get delivered to cat and not to osh.

I have to implement the trap builtin too so this could be done at the same time.

[acg]

I forget exactly how it works but I think we have to change the session group when starting a process.

Yup pretty sure you need a setsid(2).

[acg]

I forget exactly how it works but I think we have to change the session group when starting a process.

Yup pretty sure you need a setsid(2).

[icarroll]

As an aside, if OSH is the login shell for an ssh connection, ^C kills OSH and closes the connection.

[icarroll]

As an aside, if OSH is the login shell for an ssh connection, ^C kills OSH and closes the connection.

[andychu]

Also mentioned here: https://lobste.rs/s/l8r1nw/why_create_new_unix_shell#c_sfmsrv

[andychu]

Also mentioned here: https://lobste.rs/s/l8r1nw/why_create_new_unix_shell#c_sfmsrv