Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Twitter user of congressperson on Jarbas #465

Open
lucasrcezimbra opened this issue Mar 16, 2019 · 6 comments
Open

Show Twitter user of congressperson on Jarbas #465

lucasrcezimbra opened this issue Mar 16, 2019 · 6 comments

Comments

@lucasrcezimbra
Copy link
Contributor

@lucasrcezimbra lucasrcezimbra commented Mar 16, 2019

Since Rosie can no longer mention congressperson on Twitter, would be interesting if Jarbas has information about congressperson Twitter, so people can use that to reply Rosie tweets mentioning congresspeople.

Rosie mentioned they on twitter, so I think that we have the information in database. I think would be easy to show this information on Jarbas or in Django admin and would facilitate to collaborations from users.

[enhancement]

@giovanisleite
Copy link
Contributor

@giovanisleite giovanisleite commented Apr 26, 2019

Jarbas could have a button with a pre-written tweet like @congressperson could you explain this expense? link to jarbas or link to rosie tweet. The button href would be something like
this

What do you think? @Lrcezimbra @cuducos

@cuducos
Copy link
Member

@cuducos cuducos commented Apr 26, 2019

I like it : )
The text could be the same used in Rosie, maybe tagging her too. There's a class at jarbas.chamber_of_deputies.twitter (if I'm not wrong) that could offer the text given a reimbursement by the way. Nowadays it randomly selects one, but a tweak like that would do it:

class Twitter:
    def __init__(self, reimbursement=None):
        self.reimbursement = reimbursement if reimbursement else self.get_reimbursement()

@sergiomario
Copy link
Member

@sergiomario sergiomario commented May 31, 2019

@Lrcezimbra Can you check if PR #477 solves this issue?
social_media

@lucasrcezimbra
Copy link
Contributor Author

@lucasrcezimbra lucasrcezimbra commented May 31, 2019

@sergiomario I think that the PR is a good improvement, but I was thinking of putting in the Jarbas frontend instead of the admin (image below). Because the page below is linked in the tweets, then putting Twitter there will make it easier to mention congressman.

image

@luizfzs
Copy link
Contributor

@luizfzs luizfzs commented Jan 2, 2020

PR #477 has been merged. Should this issue be closed?

@lucasrcezimbra
Copy link
Contributor Author

@lucasrcezimbra lucasrcezimbra commented Jan 3, 2020

@luizfzs

@sergiomario I think that the PR is a good improvement, but I was thinking of putting in the Jarbas frontend instead of the admin (image below). Because the page below is linked in the tweets, then putting Twitter there will make it easier to mention congressman.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants