Modify rosie adapter to load files acording to starting year#476
Open
lucastt wants to merge 1 commit intookfn-brasil:masterfrom
Open
Modify rosie adapter to load files acording to starting year#476lucastt wants to merge 1 commit intookfn-brasil:masterfrom
lucastt wants to merge 1 commit intookfn-brasil:masterfrom
Conversation
Collaborator
|
I would raise a warning here. Some classifiers, such as the meal outlier, depends on the full dataset to be more accurate (it takes into account a longitudinal analysis of how much was spent in each restaurant to find the threshold for outliers). Thus I can only agree with the proposed change if we make sure classifiers with these feature are loading a model generated with the full dataset — and checking for that is complex. I do think this might add too much complexity. I'm not sure it would worth it the risk to offer less accurate suspicions as output… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
Make it possible to to specify the starting year for the loading step of rosie algorithms. With this changes will be easier to contribute to the project with low end machines.
What was done to achieve this purpose?
Was added a function to compare the year of the CSV being loaded and the parameter STARTING_YEAR. If the year of the file is greater or equal it will be loaded, else it won't.
How to test if it really works?
During the load process verify that only the files referring to years after the starting year or in the starting year were loaded.