Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Modify rosie adapter to load files acording to starting year #476
What is the purpose of this Pull Request?
What was done to achieve this purpose?
How to test if it really works?
I would raise a warning here. Some classifiers, such as the meal outlier, depends on the full dataset to be more accurate (it takes into account a longitudinal analysis of how much was spent in each restaurant to find the threshold for outliers). Thus I can only agree with the proposed change if we make sure classifiers with these feature are loading a model generated with the full dataset — and checking for that is complex.
I do think this might add too much complexity. I'm not sure it would worth it the risk to offer less accurate suspicions as output…