Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds social links to the Jarbas dashboard #477

Merged
merged 2 commits into from May 28, 2019

Conversation

@cacarrara
Copy link
Contributor

cacarrara commented May 25, 2019

What is the purpose of this Pull Request?
This change adds links to the congressperson social profile into the
Jarbas dashboard.

What was done to achieve this purpose?

  • Changed the ReimbursementModelAdmin to have the method to return the social links.
  • Added Facebook and Twitter logo images to use on links

How to test if it really works?
You can run Jarbas locally. But a screenshot follows below:
image

Who can help reviewing it?
Everyone

This change adds links to the congressperson social profile into the
Jarbas dashboard.
@sergiomario sergiomario merged commit 5f9b5dc into okfn-brasil:master May 28, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cacarrara cacarrara deleted the cacarrara:add-social-links branch Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.