Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove streetView functionality #481

Merged

Conversation

@danielSbastos
Copy link
Contributor

danielSbastos commented May 30, 2019

What is the purpose of this Pull Request?
Here we remove the street view functionality from Jarbas' reimbursements view. This is is the result of the following issue discussion #441

What was done to achieve this purpose?
All the elm code related to rendering the four street view tiles are removed.

How to test if it really works?
Access a reimbursement that previously showed the street view tiles and check that it doesn't show anymore.

Here's how it looks like:
Untitled drawing

@sergiomario sergiomario merged commit c92c8e9 into okfn-brasil:master May 31, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.