Remove streetView functionality - #481
Merged
sergiomario merged 1 commit intoMay 31, 2019
Merged
Conversation
cuducos
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
Here we remove the street view functionality from Jarbas' reimbursements view. This is is the result of the following issue discussion #441
What was done to achieve this purpose?
All the elm code related to rendering the four street view tiles are removed.
How to test if it really works?
Access a reimbursement that previously showed the street view tiles and check that it doesn't show anymore.
Here's how it looks like:
