Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosie should post tweets where suspicions that have at least 91 open days #482

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

sergiomario
Copy link
Collaborator

What is the purpose of this Pull Request?
This proposal was made to implement issue #468
According to the rules of parliamentary quota of the Chamber of Deputies, Members have up to 90 days to present the supporting documentation of expenditure.
"No caso de reembolso, o deputado tem até 90 dias para apresentar a documentação comprobatória do gasto, depois da data de prestação do serviço ou de fornecimento do produto. "

What was done to achieve this purpose?
I put a date filter to disregard suspicions from the last 90 days.

Who can help reviewing it?
@cuducos and @cacarrara

@sergiomario sergiomario requested a review from cuducos May 31, 2019 20:04
@sergiomario sergiomario changed the title feat(twitter): Rosie should post tweets where suspicions that have at least 91 open days Rosie should post tweets where suspicions that have at least 91 open days May 31, 2019
Copy link
Contributor

@caiocarrara caiocarrara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to write a test to cover this new rule, but it seems there's no tests at all for this class. Perhaps we can add it on other PR. So, approving :)

@sergiomario sergiomario merged commit 5577c12 into master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants