Rosie should post tweets where suspicions that have at least 91 open days#482
Merged
sergiomario merged 1 commit intomasterfrom Jun 1, 2019
Merged
Rosie should post tweets where suspicions that have at least 91 open days#482sergiomario merged 1 commit intomasterfrom
sergiomario merged 1 commit intomasterfrom
Conversation
…icions that have at least 91 open days
sergiomario
changed the title
caiocarrara
approved these changes
May 31, 2019
Contributor
caiocarrara
left a comment
caiocarrara
left a comment
There was a problem hiding this comment.
I would suggest to write a test to cover this new rule, but it seems there's no tests at all for this class. Perhaps we can add it on other PR. So, approving :)
cuducos
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
This proposal was made to implement issue #468
According to the rules of parliamentary quota of the Chamber of Deputies, Members have up to 90 days to present the supporting documentation of expenditure.
"No caso de reembolso, o deputado tem até 90 dias para apresentar a documentação comprobatória do gasto, depois da data de prestação do serviço ou de fornecimento do produto. "
What was done to achieve this purpose?
I put a date filter to disregard suspicions from the last 90 days.
Who can help reviewing it?
@cuducos and @cacarrara