Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing space before height and width attributes in asset img tag #618

Merged
merged 1 commit into from Oct 27, 2019

Conversation

@pv2b
Copy link
Contributor

pv2b commented Oct 27, 2019

What this PR does / why we need it:

The hero fragment allows a user to include an asset in the hero banner. However, the HTML for the img tag is broken if width and/or height is set:

<img
      class="overlay img-fluid"
      src="/images/logo.svg"
      alt="logo"width="500px"></img>

Notice missing space before width. This PR fixes this.

Release note:

Hero fragment: Added missing space before height/width attributes in <img> tag
@deepcode-ci-bot

This comment has been minimized.

Copy link

deepcode-ci-bot bot commented Oct 27, 2019

DeepCode Report (#66dda7)

DeepCode analyzed this pull request.
There are no new issues.

Copy link
Member

mpourismaiel left a comment

Thanks a lot.

@stp-ip

This comment has been minimized.

Copy link
Member

stp-ip commented Oct 27, 2019

Awesome. Thanks for the contribution. Looking forward to even more 👍

@stp-ip stp-ip merged commit 388019e into okkur:master Oct 27, 2019
2 checks passed
2 checks passed
DeepCode Found no critical issues.
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.