Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra dom update causing event removal issue #681

merged 2 commits into from Jan 11, 2020


Copy link

mpourismaiel commented Jan 11, 2020

What this PR does / why we need it:
This PR fixes jq-helpers append function that caused an update on all the nodes inside the context element, creating an update to the dom which in turn removed all the events and updates made to the element inside that context.

This also fixes scroll to top issue (unrelated to the main fix but it was a really small change, done in a separate commit).

Which issue this PR fixes:
fixes #679

Release note:

- Fixes some JS functionality not working such as navbar search and scroll to top
@mpourismaiel mpourismaiel added the bug label Jan 11, 2020
@mpourismaiel mpourismaiel added this to the v0.16.1 milestone Jan 11, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip Jan 11, 2020
@mpourismaiel mpourismaiel self-assigned this Jan 11, 2020

This comment has been minimized.

Copy link

deepcode-ci-bot bot commented Jan 11, 2020

DeepCode's analysis on #4fb641 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

stp-ip approved these changes Jan 11, 2020
@stp-ip stp-ip merged commit dbfa6f4 into okkur:master Jan 11, 2020
3 checks passed
3 checks passed
DeepCode Found no critical issues.
deploy/netlify Deploy preview ready!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.