Add missing cwd option when calling execGit function #1075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've found this issue when executing lintStaged from node v16. My current setup is as follows:
I have 2 different folders:
/path/to/project/git
=> root folder of the git repository/path/to/project
=> root folder for the project, which is NOT a git repositoryWhen executing lintStaged, the setup is as follows:
process.cwd() == /path/to/project
lintStaged({ cwd: '/path/to/project/git'})
Current directory is not a git directory!
errorAfter debugging the code, the issue seems to be that
resolveGitRepo()
is callingexecGit()
without passing the cwd parameter. Without this parameter,execGit()
is forced to fall back toprocess.cwd()
, which in my case is NOT a proper git directory.