fix(resolvePaths): return CWD-relative paths - closes #115 #116

Merged
merged 2 commits into from Dec 30, 2016

Projects

None yet

2 participants

@rodneyrehm
Contributor
rodneyrehm commented Dec 30, 2016 edited

Fixes #115 by making resolvePaths() return paths that are relative to CWD. Should gitDir be set to .., the returned path for alpha.js would be ../alpha.js.

I haven't looked too closely at all of the path computations, but it feels like this could be simplified further.

@rodneyrehm rodneyrehm fix(resolvePaths): return CWD-relative paths - closes #115 ba5c872
@@ -3,15 +3,13 @@
import expect from 'expect'
import path from 'path'
import fs from 'fs'
-import tmp from 'tmp'
@okonet
okonet Dec 30, 2016 Owner

Can you please also remove the package from package.json?

@rodneyrehm
rodneyrehm Dec 30, 2016 Contributor

removed in a separate commit

@okonet
Owner
okonet commented Dec 30, 2016

Thanks for this PR! I'd be happy to accept anything that could simplify it, so feel free to do a review.

@rodneyrehm rodneyrehm chore(package): removing obsolete devDependency "tmp" 302649f
@okonet
okonet approved these changes Dec 30, 2016 View changes
@okonet okonet merged commit 968e0d8 into okonet:master Dec 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@okonet
Owner
okonet commented Dec 30, 2016

Awesome! Thanks for your contribution. The new version should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment