Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node-13 deps issue with listr2 and uuid #868

Merged
merged 1 commit into from May 18, 2020
Merged

fix: node-13 deps issue with listr2 and uuid #868

merged 1 commit into from May 18, 2020

Conversation

cenk1cenk2
Copy link
Contributor

@cenk1cenk2 cenk1cenk2 commented May 18, 2020

About the issue cenk1cenk2/listr2#25 of listr2 with the problems of UUID when used with Node 13.x. Rollback should fix it.

Related issues in the base library: uuidjs/uuid#428

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #868 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #868   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          592       592           
  Branches       141       141           
=========================================
  Hits           592       592           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b3e2c...a9b36d6. Read the comment docs.

iiroj
iiroj approved these changes May 18, 2020
@iiroj iiroj linked an issue May 18, 2020 that may be closed by this pull request
@iiroj
Copy link
Collaborator

iiroj commented May 18, 2020

Thanks @cenk1cenk2 for the fast (and official) resolution!

@iiroj iiroj merged commit 93bc942 into okonet:master May 18, 2020
3 checks passed
@github-actions
Copy link

github-actions bot commented May 18, 2020

🎉 This PR is included in version 10.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uuid import broken in dependency listr2
2 participants