Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nanoid devDependency to remove ExperimentalWarning #874

Merged
merged 1 commit into from May 22, 2020

Conversation

iiroj
Copy link
Collaborator

@iiroj iiroj commented May 22, 2020

nanoid contains conditional exports and emits a warning on Node.js >= 13.7: ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time.

Fixes #872

nanoid contains conditional exports and emits a warning on Node.js >= 13.7: `ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time`
@iiroj iiroj requested a review from okonet May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #874   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          597       597           
  Branches       142       142           
=========================================
  Hits           597       597           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e1a4a...299cce5. Read the comment docs.

okonet
okonet approved these changes May 22, 2020
@iiroj iiroj merged commit 979da5d into master May 22, 2020
3 checks passed
@iiroj iiroj deleted the remove-nanoid branch May 22, 2020
@github-actions
Copy link

github-actions bot commented May 22, 2020

🎉 This PR is included in version 10.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time
2 participants