Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add enquirer peer dependency #883

Merged
merged 2 commits into from Jun 4, 2020
Merged

Conversation

philihp
Copy link
Contributor

@philihp philihp commented Jun 4, 2020

Enquirer became a peer dependency of Listr2 here: cenk1cenk2/listr2@cae55e9

This should be added, so that repositories including lint-staged won't see the message

npm WARN listr2@2.1.0 requires a peer of enquirer@>= 2.3.0 < 3 but none is installed. You must install peer dependencies yourself.

@philihp philihp changed the title Add enquirer peer dependency fix: Add enquirer peer dependency Jun 4, 2020
@iiroj
Copy link
Collaborator

iiroj commented Jun 4, 2020

Thanks for the PR! Can you also bump the listr2 version to ^2.1.0 to keep it in sync?

package.json Outdated
@@ -38,6 +38,7 @@
"cosmiconfig": "^6.0.0",
"debug": "^4.1.1",
"dedent": "^0.7.0",
"enquirer": "^2.3.5",
"execa": "^4.0.1",
"listr2": "^2.0.2",
Copy link
Collaborator

@iiroj iiroj Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this to "listr2": "^2.1.0" as well to keep it in sync. Remember to run yarn as well in so that the lockfile gets updated.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          597       597           
  Branches       142       142           
=========================================
  Hits           597       597           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b078324...689a9ea. Read the comment docs.

@philihp
Copy link
Contributor Author

philihp commented Jun 4, 2020

For sure, updated listr2 as well.

@philihp philihp requested a review from iiroj Jun 4, 2020
iiroj
iiroj approved these changes Jun 4, 2020
@iiroj iiroj merged commit 0daae61 into okonet:master Jun 4, 2020
3 checks passed
@iiroj
Copy link
Collaborator

iiroj commented Jun 4, 2020

Thanks a lot for this update, @philihp! 🚀

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

🎉 This PR is included in version 10.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants