Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run all git commands with submodule.recurse=false #888

Merged
merged 1 commit into from Jun 17, 2020

Conversation

iiroj
Copy link
Collaborator

@iiroj iiroj commented Jun 12, 2020

This explicitly prevents git commands from recursing into git submodules and thus causing issues with commands like stash or reset.

Fixes #884

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #888 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #888   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          599       602    +3     
  Branches       142       142           
=========================================
+ Hits           599       602    +3     
Impacted Files Coverage Δ
lib/execGit.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1904ec...ff46223. Read the comment docs.

This explicitly prevents git commands from recursing into git submodules and thus causing issues with commands like stash or reset.
@iiroj iiroj force-pushed the fix-submodule-recurse branch from a695237 to ff46223 Compare Jun 13, 2020
@iiroj iiroj requested a review from okonet Jun 16, 2020
@iiroj
Copy link
Collaborator Author

iiroj commented Jun 16, 2020

What do you think, @okonet?

okonet
okonet approved these changes Jun 17, 2020
@iiroj iiroj merged commit 86c9ed2 into master Jun 17, 2020
3 checks passed
@iiroj iiroj deleted the fix-submodule-recurse branch Jun 17, 2020
@github-actions
Copy link

github-actions bot commented Jun 17, 2020

🎉 This PR is included in version 10.2.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with submodule + git config submodule.recurse true
2 participants