Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pre-commit #910

Merged
merged 1 commit into from Sep 3, 2020
Merged

Add support for pre-commit #910

merged 1 commit into from Sep 3, 2020

Conversation

@thibmaek
Copy link
Contributor

@thibmaek thibmaek commented Sep 2, 2020

pre-commit (pre-commit.com) is a great way to implement precommit git hooks when working on mutli-language projects.
I took this implementation from prettier's example that offers support. Additional details below:

_Example when using .pre-commit-config.yaml

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    hooks:
      - id: trailing-whitespace
  - repo: https://github.com/okonet/lint-staged
    hooks:
      - id: lint-staged
See pre-commit.com
@okonet
okonet approved these changes Sep 2, 2020
@okonet
Copy link
Owner

@okonet okonet commented Sep 2, 2020

Hmm, not sure why windows CI is failing...

@thibmaek
Copy link
Contributor Author

@thibmaek thibmaek commented Sep 2, 2020

Same here @okonet , maybe retrigger it?

@codecov
Copy link

@codecov codecov bot commented Sep 3, 2020

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #910   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          602       602           
  Branches       142       142           
=========================================
  Hits           602       602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c5ac8...6bf0e50. Read the comment docs.

@okonet okonet merged commit d404d7d into okonet:master Sep 3, 2020
11 checks passed
11 checks passed
Node.js v10 on ubuntu-latest
Details
Node.js v10 on macos-latest
Details
Node.js v12 on ubuntu-latest
Details
Node.js v12 on macos-latest
Details
Node.js v14 on ubuntu-latest
Details
Node.js v14 on macos-latest
Details
Codecov
Details
Release
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@github-actions
Copy link

@github-actions github-actions bot commented Sep 3, 2020

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.