Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode mrm@2 in the documentation #976

Merged
merged 1 commit into from May 10, 2021
Merged

Hardcode mrm@2 in the documentation #976

merged 1 commit into from May 10, 2021

Conversation

@Palid
Copy link
Contributor

@Palid Palid commented May 10, 2021

Due to some changed in mrm@3 the entire installation task fails without easily searchable solution. This fixes the problem by hard locking mrm to @2 for as long as it's not solved properly.

Due to some changed in mrm@3 the entire installation task fails without easily searchable solution. This fixes the problem by hard locking mrm to @2 for as long as it's not solved properly.
@Palid
Copy link
Contributor Author

@Palid Palid commented May 10, 2021

Example of the issue:

❯ npx mrm lint-staged
npx: installed 298 in 9.141s

Preset “default” not found.

We’ve tried to load “mrm-preset-default” and “default” npm packages.

Loading

@iiroj
Copy link
Collaborator

@iiroj iiroj commented May 10, 2021

Thanks @Palid!

Loading

@iiroj
Copy link
Collaborator

@iiroj iiroj commented May 10, 2021

I believe this fixes #970

Loading

@codecov
Copy link

@codecov codecov bot commented May 10, 2021

Codecov Report

Merging #976 (c31df34) into master (e5e186d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #976   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          611       611           
  Branches       144       144           
=========================================
  Hits           611       611           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e186d...c31df34. Read the comment docs.

Loading

iiroj
iiroj approved these changes May 10, 2021
@okonet
Copy link
Owner

@okonet okonet commented May 10, 2021

Hmm I wonder if that’s the best way. @sapegin could you please take a look at why it’s not working anymore?

Loading

@Palid
Copy link
Contributor Author

@Palid Palid commented May 10, 2021

@okonet I think that it's not a best way to do it, but it's better to have this temporary fix for documentation and figure out what's wrong there instead of having it broken without any simple solution. IMHO the best way to fix it now would be to merge this and revert it with the proper fix later. I can try investigating more on Wednesday too.

Loading

@okonet
Copy link
Owner

@okonet okonet commented May 10, 2021

I agree! Thanks for it. Let’s merge it.

Loading

okonet
okonet approved these changes May 10, 2021
@okonet okonet merged commit 4f9a146 into okonet:master May 10, 2021
11 checks passed
Loading
@iiroj iiroj linked an issue that may be closed by this pull request May 11, 2021
@Palid
Copy link
Contributor Author

@Palid Palid commented May 19, 2021

@okonet seems like a fix is waiting in the merge queue for a while now: sapegin/mrm#163

Loading

@github-actions
Copy link

@github-actions github-actions bot commented Jul 13, 2021

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants