Remove filetype check for preview #322

wants to merge 1 commit into


None yet

3 participants

zenners commented Jan 11, 2017

I used to be able to preview PDFs. This PR seemed simple enough haha

@zenners zenners preview not just images connects #318

Current coverage is 95.58% (diff: 100%)

Merging #322 into master will not change coverage

@@             master       #322   diff @@
  Files             3          3          
  Lines           136        136          
  Methods          20         20          
  Messages          0          0          
  Branches         32         32          
  Hits            130        130          
  Misses            6          6          
  Partials          0          0          

Powered by Codecov. Last update 4d40ce5...a992a9d

@zenners zenners changed the title from preview not just images connects #318 to Remove filetype check for preview Jan 11, 2017
okonet commented Jan 11, 2017 edited

Hmm, it should have fail the test but it didn't 🤔


This is embarrassing but I forgot to remove .skip from the test:

Can you please update the spec file as well so it corresponds this behavior. Also, should this be considered a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment