Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): pull every task in a styled card & bold h3 elements #24

Merged
merged 2 commits into from Dec 5, 2022

Conversation

fredericvilcot
Copy link
Contributor

Because of @bot-anik that has closed #23, the aim of this PR is to "beautify" the tasks page in a extra fast way by putting each task in a styled card, as done for the leaderboard elements.

Here are two videos:

desktop 1440px:
https://user-images.githubusercontent.com/47554752/205330376-6b8ca2bf-7bdb-4607-81ea-9f804802a106.mov

iPhone 12 Pro:
https://user-images.githubusercontent.com/47554752/205330439-c1f38b59-6887-4db1-88b4-22dbb13740be.mov

Just tell me if you think this improvement should be deployed in production.

@fredericvilcot
Copy link
Contributor Author

@JulienMassonnat

It's weird, on my side the font is 'Gotham' not Arial ...

image

@JulienMassonnat
Copy link
Member

Nope the font displayed is Arial for sure.
The explorer is wrong.

@JulienMassonnat
Copy link
Member

Here is the right declaration from the Design System
image

@fredericvilcot
Copy link
Contributor Author

@JulienMassonnat

Yep, you're right...
The issue is that Gotham font with bold and italic is broken at line-height level...

image

I need to find a way to fix it

@JulienMassonnat
Copy link
Member

It works well on local with these
image

@fredericvilcot
Copy link
Contributor Author

yes because there is large padding between elements and no other element than a <p> near to him.

But next to the icon it gives this:

image

It's a well known issue with the Gotham font...

@fredericvilcot
Copy link
Contributor Author

fredericvilcot commented Dec 2, 2022

@JulienMassonnat @emmanuelaldeguer @ccamel

I 'hacked' the way to use Gotham font with both bold and italic weight and styles for title description.
I also removed the bold weight for points because it was bold for the title and the text, too heavy for the eye...

Let me knøw!

image

@fredericvilcot
Copy link
Contributor Author

@JulienMassonnat

Go?

@JulienMassonnat
Copy link
Member

LGTM ! Thanks @fredericvilcot

@fredericvilcot fredericvilcot merged commit 795783b into main Dec 5, 2022
@fredericvilcot fredericvilcot deleted the feat/beautify-tasks-page-v3 branch December 5, 2022 10:12
@fredericvilcot fredericvilcot restored the feat/beautify-tasks-page-v3 branch December 5, 2022 10:12
@fredericvilcot fredericvilcot deleted the feat/beautify-tasks-page-v3 branch December 5, 2022 10:12
@bot-anik
Copy link
Member

bot-anik commented Dec 6, 2022

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants