Skip to content

Update to Ubuntu bionic - #4

Merged
colinschoen merged 3 commits into
okpy:masterfrom
icokpy:update-to-ubuntu-bionic
Jun 15, 2018
Merged

Update to Ubuntu bionic#4
colinschoen merged 3 commits into
okpy:masterfrom
icokpy:update-to-ubuntu-bionic

Conversation

@c-w

@c-w c-w commented Jun 12, 2018

Copy link
Copy Markdown
Contributor

Note that this pull request depends on #2 and #3 and so should be reviewed/merged after them.

This pull request updates the image to the latest Ubuntu version (bionic). This enables us to get rid of the custom PPA for Python 3.6 since that is now the default version.

The pull request also introduces assorted improvements to reduce images size. Previously, the image was 1.15GB in size. Combining the layers, cleaning up after each layer (to avoid results that are later cleaned up being written into the intermediate images), removing the pip cache and avoiding to install recommended packages brings down the size by about 30% to 827MB. The smaller image size is notable when running the autograder on a service like Azure Container Instances or AWS Fargate.

c-w and others added 3 commits June 12, 2018 12:02
Installing the pdf package via pip currently fails with the error:

```
Could not find a version that satisfies the requirement pdf (from versions: )
No matching distribution found for pdf
```

PyPDF2 [1] has a similar set of functionality and installs cleanly.

[1] https://pythonhosted.org/PyPDF2/
Also: assorted improvements to reduce images size. Previously, the image
was 1.15GB in size. Combining the layers, cleaning up after each layer
(to avoid results that are later cleaned up being written into the
intermediate images), removing the pip cache and avoiding to install
recommended packages brings down the size by about 30% to 827MB.

@colinschoen colinschoen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschoen
colinschoen merged commit 21495e3 into okpy:master Jun 15, 2018
@c-w
c-w deleted the update-to-ubuntu-bionic branch June 15, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants