Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ubuntu bionic #4

Merged
merged 3 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Jun 12, 2018

Note that this pull request depends on #2 and #3 and so should be reviewed/merged after them.

This pull request updates the image to the latest Ubuntu version (bionic). This enables us to get rid of the custom PPA for Python 3.6 since that is now the default version.

The pull request also introduces assorted improvements to reduce images size. Previously, the image was 1.15GB in size. Combining the layers, cleaning up after each layer (to avoid results that are later cleaned up being written into the intermediate images), removing the pip cache and avoiding to install recommended packages brings down the size by about 30% to 827MB. The smaller image size is notable when running the autograder on a service like Azure Container Instances or AWS Fargate.

c-w and others added some commits Jun 12, 2018

Remove uninstallable pdf package
Installing the pdf package via pip currently fails with the error:

```
Could not find a version that satisfies the requirement pdf (from versions: )
No matching distribution found for pdf
```

PyPDF2 [1] has a similar set of functionality and installs cleanly.

[1] https://pythonhosted.org/PyPDF2/
Update to Ubuntu bionic
Also: assorted improvements to reduce images size. Previously, the image
was 1.15GB in size. Combining the layers, cleaning up after each layer
(to avoid results that are later cleaned up being written into the
intermediate images), removing the pip cache and avoiding to install
recommended packages brings down the size by about 30% to 827MB.
@colinschoen
Copy link
Member

left a comment

LGTM

@colinschoen colinschoen merged commit 21495e3 into okpy:master Jun 15, 2018

@c-w c-w deleted the icokpy:update-to-ubuntu-bionic branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.