Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable tests to run on Windows #1242
I checked out the repository, followed the setup instructions and then ran the tests. I saw some errors so I thought that there is something wrong with my setup. After a bit of digging, I found out that my setup of the repository is fine but that some of the tests assume a *nix runtime or specific running external services.
In order to prevent this confusion for future developers, I thought to fix the tests on Windows such that after following all the setup steps, a new developer would get a clean test run and that any tests which can't run on the developer's machine are skipped instead of failed.
Specifically, this pull request implements the following:
The pull request also contains one unrelated fix that I noticed while working:
For more detail on the changes above, please refer to the commit descriptions.
After applying this PR, following the setup and running the tests will lead to a clean test run on Windows:
Note that I do still get one error when running the tests (as seen in the screenshot above) but I also see that error when running the tests via Docker on the latest master (see screenshot below), so I'm assuming that this is a known issue and unrelated to my PR.