Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all settings match old values #1264

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented May 4, 2018

This fixes a regression introduced in ec06b9c where the settings were refactored into a class hierarchy but some values were changed by accident as part of this refactor.

The fix was verified by logging out the configs on the commit before the refactor, applying the refactor, logging out the configs again and then diffing the results.

Snippet used to log the configs:

with open('config-' + app.config['ENV'] + '.txt', 'w') as fobj:
    config = str(app.config).replace(', ', ',\n')
    fobj.write(config)

Paired with @liliankasem

Ensure that all settings match old values
This fixes a regression introduced in ec06b9c where the settings were
refactored into a class hierarchy but some values were changed by
accident as part of this refactor.

The fix was verified by logging out the configs on the commit before the
refactor, applying the refactor, logging out the configs again and then
diffing the results.

Snippet used to log the configs:

```py
with open('config-' + app.config['ENV'] + '.txt', 'w') as fobj:
    config = str(app.config).replace(', ', ',\n')
    fobj.write(config)
```

Paired with @liliankasem
@colinschoen
Copy link
Member

left a comment

Thanks Clemens. I should have done that when reviewing.

LGTM

@colinschoen colinschoen merged commit 5b13a02 into okpy:master May 4, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the icokpy:bug/imperial/config-fixes branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.