Ensure that all settings match old values #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in ec06b9c where the settings were refactored into a class hierarchy but some values were changed by accident as part of this refactor. The fix was verified by logging out the configs on the commit before the refactor, applying the refactor, logging out the configs again and then diffing the results. Snippet used to log the configs: ```py with open('config-' + app.config['ENV'] + '.txt', 'w') as fobj: config = str(app.config).replace(', ', ',\n') fobj.write(config) ``` Paired with @liliankasem
colinschoen
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in ec06b9c where the settings were refactored into a class hierarchy but some values were changed by accident as part of this refactor.
The fix was verified by logging out the configs on the commit before the refactor, applying the refactor, logging out the configs again and then diffing the results.
Snippet used to log the configs:
Paired with @liliankasem