Ensure that make and docker share the same image #1266
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `make docker-build` command creates a custom tagged image called `cs61a/ok-server`. The `make docker-test` command, on the other hand, delegates to docker-compose which will assign its own image name based on the service name declared in the compose file (`web`). This means that in some situations docker-compose will unnecessarily rebuild the image. Specifying an explicit image name in the compose file eliminates this inconsistency and ensures that both make recipes will always use the same image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
make docker-buildcommand creates a custom tagged image calledcs61a/ok-server. Themake docker-testcommand, on the other hand, delegates to docker-compose which will assign its own image name based on the service name declared in the compose file (web).This means that in some situations docker-compose will unnecessarily rebuild the image. Specifying an explicit image name in the compose file eliminates this inconsistency and ensures that both make recipes (
make docker-buildandmake docker-test) will always use the same image.